Skip to content

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Feb 4, 2021

This reverts #8937, which seems to have caused a permission issue.

cc #9127

@rust-highfive
Copy link

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.50.0. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 4, 2021
@ehuss
Copy link
Contributor Author

ehuss commented Feb 4, 2021

I'm not sure if there is enough time to get this in, but I think it might be a good idea.

@Eh2406
Copy link
Contributor

Eh2406 commented Feb 4, 2021

Makes sense, @alexcrichton what do you think?

@alexcrichton
Copy link
Member

@bors: r+

I always forget this aspect of fs::copy...

@bors
Copy link
Contributor

bors commented Feb 4, 2021

📌 Commit 736de0d has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2021
@bors
Copy link
Contributor

bors commented Feb 4, 2021

⌛ Testing commit 736de0d with merge f04e7fa...

@bors
Copy link
Contributor

bors commented Feb 4, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing f04e7fa to rust-1.50.0...

@bors bors merged commit f04e7fa into rust-lang:rust-1.50.0 Feb 4, 2021
@ehuss ehuss added this to the 1.50.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants