Fix some clippy warnings #9329
Fix some clippy warnings #9329
Conversation
fixes these clippy warnings: map_collect_result_unit needless_borrow needless_return into_iter_on_ref manual_flatten match_like_matches_macro bool_comparison
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Thanks for the PR! I'm a bit confused though, as this seems to resubmit a previous PR (#9323)? Generally I would prefer to not make most of these changes, as they seem to be either subjective stylistic changes and things that don't really improve readability to me. |
|
Thanks for your reply! My PR is independent of #9323; it extends it. Which changes are you referring to? Clippy warnings in general or those of my PR in particular? I've chopped my changes into dedicated commits which allows for selecting those that are good to push. What do you think of my two commits involving "field_reassign_with_default"? |
|
Ah, I get what you mean... Why is the commit from PR #9323 mentioned in this one? I have no idea... |
|
I'm going to close this out as we are not accepting clippy PRs at this time. Thanks again, though. |
No description provided.