-
Notifications
You must be signed in to change notification settings - Fork 502
Use std::thread::available_parallelism
for determining the default number of jobs
#1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
041a0a8
to
1ef467d
Compare
1ef467d
to
3c8eb2d
Compare
Changed the code, let me know what do you think :) I used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine after formatting nit, thanks!
3c8eb2d
to
b94051a
Compare
Reformatted. |
CI failure is unrelated, due to stable Rust being bumped :) Might be better to pin Rust versions on CI. |
I think they are fixed on main, so if you rebase it should be fine? If my memory is wrong and it isn't fixed, can you please fix it? I prefer not to pin rust versions and use latest releases |
They don't look to be solved, I'll fix them in this PR then. |
…number of jobs The function was stabilized in 1.59, while the current MSRV is 1.63.
b94051a
to
23ffd6d
Compare
I fixed most of the issues, but there is a problem with using the |
Hmm, CI is green, but it failed locally 🤷♂️ Good enough for me I guess, maybe I ran Clippy in a different way than was expected. |
Ohh it's a clippy we setup for our project, if you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The function was stabilized in 1.59, while the current MSRV is 1.63.