Add __floatdisf and __floatundisf intrinsics #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks like CI may be failing though, but I think that's just due to the need to remove these files getting built from the build script? |
|
It also looks like there's an implementation optimized for i386, perhaps that could still be compiled in and used by default? |
|
I plead the I-don't-know-what-I'm-doing. It doesn't look like these CI failures are anything to do with me, but I've left this PR open to maintainers. It's been a while since I had cause to touch this repo, and I don't want to poke blindly. |
|
Oh no worries! I think this should be fixed by removing these two lines |
kevinaboos
added a commit
to theseus-os/Theseus
that referenced
this pull request
Apr 19, 2018
kevinaboos
added a commit
to theseus-os/Theseus
that referenced
this pull request
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this some months back for personal use - I didn't create a PR then because I suspected the actual solution should be more involved than cargo-culting the existing implementation of
__floatdidfand__floatundidfand changing the type, but @alexcrichton said I should be bold.Resolves issue #216.