Use the compiler to determine whether or not to enable f16 and f128
#963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
f16-f128-enabled-cfg
branch
7 times, most recently
from
0fd2c46 to
f9f1204
Compare
Currently we whether or not to build and test `f16` and `f128` support
mostly based on the target triple. This isn't always accurate, however,
since support also varies by backend and the backend version.
Since recently, `rustc` is aware of this with the unstable config option
`target_has_reliable_{f16,f128}`, which better represents when the types
are actually expected to be available and usable. Switch our
compiler-builtins and libm configuration to use this by probing `rustc`
for the target's settings.
A few small `cfg` fixes are needed with this.
tgross35
force-pushed
the
f16-f128-enabled-cfg
branch
from
f9f1204 to
ed17b95
Compare
Amanieu
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we whether or not to build and test
f16andf128supportmostly based on the target triple. This isn't always accurate, however,
since support also varies by backend and the backend version.
Since recently,
rustcis aware of this with the unstable config optiontarget_has_reliable_{f16,f128}, which better represents when the typesare actually expected to be available and usable. Switch our
compiler-builtins and libm configuration to use this by probing
rustcfor the target's settings.
A few small
cfgfixes are needed with this.