Skip to content

Reintegrate chalk into rustc #289

Closed
Closed
@jackh726

Description

@jackh726
Member

TL;DR

Reintegrate chalk into rustc using chalk-solve under the -Z chalk flag.

Links and Details

This is working towards the eventual™ goal of using Chalk as the rustc trait solver. There used to be an experimental implementation of Chalk in rustc using chalk-engine. It became outdated and was removed in rust-lang/rust#69247. Since that first experimental implementation was added, Chalk has gone through lots of changes, including adding a new crate, chalk-solve, which is supposed to implement Rust logic. As such, with this newer implementation, the interface between rustc and Chalk is a bit higher-level.

The PR for this initial MVP implementation is here: rust-lang/rust#69406

Mentors or Reviewers

c.c. @nikomatsakis
c.c. @rust-lang/wg-traits

Activity

added
T-compilerAdd this label so rfcbot knows to poll the compiler team
major-changeA proposal to make a major change to rustc
on May 7, 2020
nikomatsakis

nikomatsakis commented on May 7, 2020

@nikomatsakis
Contributor

@rustbot second

I'm going to exercise the "I consider this unlikely to be controversial clause" and r+ rust-lang/rust#69406 before it bitrots...we can always back it out. (Besides, if I know bors, it'll take 2 weeks to land anyway 😛)

added
final-comment-periodThe FCP has started, most (if not all) team members are in agreement
on May 7, 2020
nikomatsakis

nikomatsakis commented on May 28, 2020

@nikomatsakis
Contributor

Closing, FCP expired. =)

added and removed
final-comment-periodThe FCP has started, most (if not all) team members are in agreement
on Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was accepted

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @spastorino@nikomatsakis@jackh726@rustbot

        Issue actions

          Reintegrate chalk into rustc · Issue #289 · rust-lang/compiler-team