Skip to content

Create a notification group for WASM #794

@juntyr

Description

@juntyr

Proposal

A new notification group “wasm” is created for the WASM targets. The group will use the existing O-wasm, O-wasi, and O-emscripten labels. The notification group will provide target-specific expertise when needed (and reduce the amount of pings specifically for @alexcrichton).

The group will also have aliases for “wasi” and “emscripten”.

Mentors or Reviewers

@jieyouxu

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Activity

added
major-changeA proposal to make a major change to rustc
T-compilerAdd this label so rfcbot knows to poll the compiler team
on Oct 15, 2024
rustbot

rustbot commented on Oct 15, 2024

@rustbot
Collaborator

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:

@rustbot concern reason-for-concern 
<description of the concern> 

Concerns can be lifted with:

@rustbot resolve reason-for-concern 

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler @rust-lang/compiler-contributors

jieyouxu

jieyouxu commented on Oct 15, 2024

@jieyouxu
Member

Discussed with @davidtwco, we didn't think that this needed an MCP, so I'm going to mark this as accepted without the final comment period.

@rustbot second

added
final-comment-periodThe FCP has started, most (if not all) team members are in agreement
on Oct 15, 2024
jieyouxu

jieyouxu commented on Oct 15, 2024

@jieyouxu
Member

As mentioned above

@rustbot label -final-comment-period +major-change-accepted

added and removed
final-comment-periodThe FCP has started, most (if not all) team members are in agreement
on Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was accepted

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @apiraino@jieyouxu@rustbot@juntyr

        Issue actions

          Create a notification group for WASM · Issue #794 · rust-lang/compiler-team