Skip to content

add fortran to build environment #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 15, 2019
Merged

add fortran to build environment #24

merged 3 commits into from
Dec 15, 2019

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 3, 2019

@jyn514
Copy link
Member Author

jyn514 commented Dec 7, 2019

@pietroalbini do you know why CI is failing? It doesn't seem to be related to this change.

@pietroalbini
Copy link
Member

@jyn514 pushed a commit to actually show the diff when linting fails:

--- /tmp/sorted-packages.txt    2019-12-09 09:35:25.812465059 +0100
+++ packages.txt        2019-12-09 09:34:54.064944260 +0100
@@ -23,8 +23,8 @@
 dselect
 emacsen-common
 enchant
-gfortran
 git
+gfortran
 gnupg
 golang
 gstreamer1.0-plugins-base

Also pushed another commit to fix the lint.

@jyn514
Copy link
Member Author

jyn514 commented Dec 9, 2019

It looks like the version of diff on Travis doesn't have a --color option:
https://travis-ci.com/rust-lang/crates-build-env/jobs/265107590#L461

@jyn514
Copy link
Member Author

jyn514 commented Dec 10, 2019

LGTM, is this waiting on anything?

@jyn514 jyn514 merged commit d2cfd44 into rust-lang:master Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Fortran compiler available
2 participants