Skip to content

GitHub profile link sometimes works #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frewsxcv opened this issue May 13, 2017 · 2 comments
Closed

GitHub profile link sometimes works #724

frewsxcv opened this issue May 13, 2017 · 2 comments

Comments

@frewsxcv
Copy link
Member

  1. go to https://crates.io/users/frewsxcv
  2. github link doesn't work
  3. click on a crate
  4. click browser back
  5. github link works

untitled

@nisargthakkar
Copy link
Contributor

nisargthakkar commented May 14, 2017

@carols10cents I tried looking into what is going on here. It seems that the github url is set in the pub fn encodable(self) -> EncodableOwner method in the src/owners.rs file. This function is not called on the users/ route. In the /users route, pub fn encodable(self) -> EncodableUser method in the src/user/mod.rs file is responsible to provide the model for EmberJS to pick up and display the data. When the user goes to the /crates route, the src/owners.rs file is hit and it adds the github url in the store. So, the next time the user hits the /users route, the url is already present.

I am new to Rust and not very familiar with EmberJS. So, some terminology I've used or my understanding of the code might be totally wrong. Anyways, I'd like to pick this task up

natboehm added a commit to natboehm/crates.io that referenced this issue Jun 20, 2017
@carols10cents
Copy link
Member

This was fixed in #727!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants