Skip to content

Yanked crates shouldn't be displayed on user/team pages #958

Closed
@carols10cents

Description

@carols10cents

Related to #145.

Since we currently only keep track of yanked-ness on version records rather than on crate records, implementing this involves:

  • Changing the query for the crates a user owns and the query for the crates a team owns to have an additional condition that there must be at least one version associated with that crate that has yanked equal to false.
    • I expect figuring out the diesel incantation to express this condition to be the most difficult part of this issue; give it a try and post what you've tried and I can help figure it out if you get stuck!
  • Make a new test similar to this one that if the user or team in the test owns a crate where all versions have been yanked, that crate does NOT show up in the JSON response.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancement ✨Category: Adding new behavior or a change to the way an existing feature worksE-has-mentor

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions