Fixes errors on "not found" pages #1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes "not found" pages that were showing errors since we disabled prototype extensions
Queue a flash message and then redirect to the home page Not doing this for crates, I think I'd rather do a search by default or something?
|
bors: r+ Thanks @carols10cents! |
bors-voyager bot
added a commit
that referenced
this pull request
Sep 23, 2017
1076: Fixes errors on "not found" pages r=Turbo87 Turns out when we were checking for crate/category/etc not being found, we were using `any` from the ember prototype extensions. This PR changes those spots to use `some` instead, and cleans up a few other inconsistencies I noticed. I tried to write tests for "not found" pages, but that's proving to be a bit more.... interesting... so I decided to open this up to fix production first. r? @Turbo87
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out when we were checking for crate/category/etc not being found, we were using
anyfrom the ember prototype extensions. This PR changes those spots to usesomeinstead, and cleans up a few other inconsistencies I noticed.I tried to write tests for "not found" pages, but that's proving to be a bit more.... interesting... so I decided to open this up to fix production first.
r? @Turbo87