DO NOT MERGE until after 2019-03-01; Remove date checks for verified email requirement #1630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carols10cents
force-pushed
the
after-2019-02-28
branch
from
3987920 to
14239e4
Compare
sgrif
approved these changes
Feb 22, 2019
5 tasks
Then manually remove or edit the email record if we're specifically testing a user without a verified email address.
Remove all code and tests having to do with the warnings we issued and the date checking around the cutover date.
carols10cents
force-pushed
the
after-2019-02-28
branch
from
14239e4 to
dacafbc
Compare
|
Merging this to get tests passing again; sgrif already approved. @bors r+ |
|
📌 Commit dacafbc has been approved by |
bors
added a commit
that referenced
this pull request
Mar 1, 2019
DO NOT MERGE until after 2019-03-01; Remove date checks for verified email requirement This removes the date checks added in #1629 so that an email address is always required. The integration tests will start failing after 2019-03-01 00:00:00 UTC; this is the cure.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the date checks added in #1629 so that an email address is always required. The integration tests will start failing after 2019-03-01 00:00:00 UTC; this is the cure.