Skip to content

Fix mismatch in crate versions between pages #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix mismatch in crate versions between pages #2751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/components/crate-row.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
>
{{ @crate.name }}
</LinkTo>
<span local-class="version" data-test-version>v{{@crate.max_version}}</span>
<CrateTomlCopy @copyText='{{@crate.name}} = "{{@crate.max_version}}"' @inline={{true}} local-class="copy-button" />
<span local-class="version" data-test-version>v{{@crate.newest_version}}</span>
<CrateTomlCopy @copyText='{{@crate.name}} = "{{@crate.newest_version}}"' @inline={{true}} local-class="copy-button" />
</div>
<div local-class="description" data-test-description>
{{ truncate-text @crate.description }}
Expand All @@ -28,7 +28,7 @@
<div local-class="updated-at" >
{{svg-jar "latest-updates" height="32" width="32"}}
<span>
<abbr title="The last time crate was updated">Updated:</abbr>
<abbr title="The last time the crate was updated">Updated:</abbr>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or this maybe to match the other hover titles?

Suggested change
<abbr title="The last time the crate was updated">Updated:</abbr>
<abbr title="Last time crate was updated">Updated:</abbr>

<time title="Last updated: {{ @crate.updated_at }}" datetime="{{ moment-format @crate.updated_at 'YYYY-MM-DDTHH:mm:ssZ' }}" data-test-updated-at>
{{ moment-from-now @crate.updated_at }}
</time>
Expand All @@ -47,4 +47,4 @@
{{/if}}
</ul>

</div>
</div>