Leverage readme_path to support relative paths from readme's not at root #3861
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @smarnach (or someone else) soon. Please see the contribution instructions for more information. |
|
Here's me doing the best I can to show a screenshot of my manual test. |
Turbo87
added
A-backend ⚙️
C-enhancement ✨
|
☔ The latest upstream changes (presumably #3862) made this pull request unmergeable. Please resolve the merge conflicts. |
Added unit tests for publishing with - cargo.toml in root + readme in root - cargo.toml in root + readme in subdir - cargo.toml in subdir + readme next to it - cargo.toml in subdir + readme in root (../README) Should fix rust-lang/crates.io#3484 in combination with rust-lang/crates.io#3861
Added unit tests for publishing with - cargo.toml in root + readme in root - cargo.toml in root + readme in subdir - cargo.toml in subdir + readme next to it - cargo.toml in subdir + readme in root (../README) Should fix rust-lang/crates.io#3484 in combination with rust-lang/crates.io#3861
|
☔ The latest upstream changes (presumably #3880) made this pull request unmergeable. Please resolve the merge conflicts. |
Added unit tests to confirm things work. Manually tested end to end and confirmed that the rendered page has a properly working relative link as long as the Cargo.toml is in the root of the repo. We'll need to update cargo as mentioned in rust-lang#3484 in order to support Cargo.toml that aren't in the root of the repo
|
(rebased on master - to handle merge conflicts) |
|
@bors r+ |
|
📌 Commit cd4e08b has been approved by |
|
☀️ Test successful - checks-actions |
Extract `cio_markdown` subpackage This allows us to isolate our markdown rendering code in a dedicated package, which could potentially have a positive effect on the compile times of the full project. It also means we can iterate on this part of the code independent from the other parts (see #3861 or #3297), and with a well-defined API interface.
Added unit tests to confirm things work.
Manually tested end to end and confirmed that the rendered
page has a properly working relative link as long as the Cargo.toml
is in the root of the repo.
We'll need to update cargo as mentioned in #3484 in order to
support Cargo.toml that aren't in the root of the repo