Skip to content

Use json! macro to simplify JSON serialization code #3889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 4, 2021
Merged

Use json! macro to simplify JSON serialization code #3889

merged 19 commits into from
Sep 4, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Sep 3, 2021 •
edited
Loading

see https://docs.serde.rs/serde_json/macro.json.html

I guess +132 −349 speaks for itself 😅

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Sep 3, 2021
0xPoe
0xPoe reviewed Sep 4, 2021
View reviewed changes
Copy link
Member

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks as simple as returning json in JavaScript!

0xPoe
0xPoe reviewed Sep 4, 2021
View reviewed changes
Turbo87 added 19 commits September 4, 2021 11:29
@Turbo87
errors::json: Use json! macro to simplify JSON serialization code
da37e26
@Turbo87
controllers::helpers: Use json! macro to simplify JSON serializatio…
f285b17 
…n code
@Turbo87
controllers::krate::downloads: Use json! macro to simplify JSON ser…
7c843f2 
…ialization code
@Turbo87
controllers::krate::follow: Use json! macro to simplify JSON serial…
263c2d1 
…ization code
@Turbo87
controllers::krate::metadata: Use json! macro to simplify JSON seri…
e36d08e 
…alization code
@Turbo87
controllers::krate::owners: Use json! macro to simplify JSON serial…
f2b7e53 
…ization code
@Turbo87
controllers::krate::search: Use json! macro to simplify JSON serial…
0424d29 
…ization code
@Turbo87
controllers::user::me: Use json! macro to simplify JSON serializati…
103f23c 
…on code
@Turbo87
controllers::user::other: Use json! macro to simplify JSON serializ…
611c5db 
…ation code
@Turbo87
controllers::user::session: Use json! macro to simplify JSON serial…
6438e7b 
…ization code
@Turbo87
controllers::version::deprecated: Use json! macro to simplify JSON …
37f111a 
…serialization code
@Turbo87
controllers::version::downloads: Use json! macro to simplify JSON s…
9fd5d56 
…erialization code
@Turbo87
controllers::version::metadata: Use json! macro to simplify JSON se…
c39e7d6 
…rialization code
@Turbo87
controllers::category: Use json! macro to simplify JSON serializati…
39283e6 
…on code
@Turbo87
controllers::crate_owner_invitation: Use json! macro to simplify JS…
43784d6 
…ON serialization code
@Turbo87
controllers::keyword: Use json! macro to simplify JSON serializatio…
99e7ad8 
…n code
@Turbo87
controllers::site_metadata: Use json! macro to simplify JSON serial…
8726c20 
…ization code
@Turbo87
controllers::team: Use json! macro to simplify JSON serialization code
d450176
@Turbo87
controllers::token: Use json! macro to simplify JSON serialization …
2c2536a 
…code
0xPoe
0xPoe approved these changes Sep 4, 2021
View reviewed changes
Copy link
Member

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@0xPoe
Copy link
Member

0xPoe commented Sep 4, 2021

If there are no other objections, please feel free to r=me.

@Turbo87
Copy link
Member Author

Turbo87 commented Sep 4, 2021

@bors r=hi-rustin

@bors
Copy link
Contributor

bors commented Sep 4, 2021

📌 Commit 2c2536a has been approved by hi-rustin

@bors
Copy link
Contributor

bors commented Sep 4, 2021

⌛ Testing commit 2c2536a with merge c00bc1c...

@bors
Copy link
Contributor

bors commented Sep 4, 2021

☀️ Test successful - checks-actions
Approved by: hi-rustin
Pushing c00bc1c to master...

@bors bors merged commit c00bc1c into rust-lang:master Sep 4, 2021
@Turbo87 Turbo87 deleted the json-macro branch September 6, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xPoe 0xPoe 0xPoe approved these changes

Assignees

@jtgeibel jtgeibel

@0xPoe 0xPoe

Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Turbo87 @0xPoe @bors @jtgeibel @rust-highfive