Fix link in CONTRIBUTING.md #775
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"ember-cli-moment-shim" takes care of that for us automatically
This is already imported by ember-cli-qunit
— Elliot Jackson <[email protected]>
carols10cents
force-pushed
the
fix-docs-link
branch
from
06d1208 to
0eee892
Compare
Cleanup Ember dependencies
— Elliot Jackson <[email protected]>
|
Hmm. Haven't worked with git rebase before and think I've made a mess of this. @carols10cents should I start this PR again or is the above the expected output of a rebase? |
|
@elliotekj Don't worry about it, I can take care of it :) |
|
I cherry-picked your commit onto master-- thank you!! |
|
@carols10cents Thanks! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a line break and a space in the middle of the "E-Mentor" URL resulting in this:
This PR just fixes the links formatting.