DatabaseBackend::get is a panic waiting to happen

[jyn514]

docs.rs/src/storage/database.rs

Line 37 in 9da04c0

(CASE WHEN LENGTH(content) <= $2 THEN content ELSE NULL END) AS content,

returns NULL if the file is too big. But blob.content is a Vec, not an Option<Vec>. So

docs.rs/src/storage/database.rs

Line 65 in 9da04c0

content: row.get("content"),

will panic whenever the content is NULL.

Fortunately, the database backend isn't used in prod, but this is something to be aware of when self-hosting or running tests.

This was caught while working on #874.

[jyn514]

Oh hold on, this explicitly checks for the case when it's NULL above:

docs.rs/src/storage/database.rs

Line 38 in 9da04c0

(LENGTH(content) > $2) AS is_too_big

and

docs.rs/src/storage/database.rs

Lines 49 to 50 in 9da04c0

	if row.get("is_too_big") {
	return Err(std::io::Error::new(

So this can't be hit even in theory.