-
Notifications
You must be signed in to change notification settings - Fork 212
"Go to latest version" should ignore yanked versions #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yanked versions should be filtered from Line 241 in 5727d15
|
Would this get fixed by #322? |
It's related: would allow replacing the snippet above with let versions_without_yanked = &crate_details.versions
.filter(|v| !&crate_details.yanked.contains(v));
let latest_version = latest_version(versions_without_yanked, &version); |
Oh wait, |
Still related. #396 (comment) would apply if you added |
Should be fixed by #739, the futures crate is no longer a good testcase unfortunately, but there's internal tests covering it. |
Clicking "Go to latest version" at https://docs.rs/futures/0.1.28/futures/ opens the docs for version
0.2.3-docs-yank.4
and then redirects back to0.1.28
.Expected behavior:
should open the latest non-yanked version,0.2.1
.should not display "Go to latest version" since
0.1.28
is already the latest version;for
0.1.27
should open0.1.28
directly instead of opening the yanked version first.Related: #112, #221
The text was updated successfully, but these errors were encountered: