-
Notifications
You must be signed in to change notification settings - Fork 212
Add support for blacklisting crates #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Here are some mentoring instructions for this issue!
You can learn how to contribute to docs.rs in the README, and feel free to ask questions here or on Discord (channel |
Hi @pietroalbini, thank you for the clear instructions! I would like to work on this. |
I have a question about how the filtering / blacklisting should function: if I understand this issue correctly, we want to prevent new versions of a known 'bad' crate to be built and added to doc.rs. Q's:
The simple implementation I have working now only stores a crate name in |
Closed in #539 |
Some of the crates on docs.rs are blacklisted for legal reasons, but are still up on crates.io. Before #529 was merged we disabled them globally by blocking the route in nginx, but I'd like to move away from that model.
Deleting the old content is already covered by the
delete-crate
command, but even with that new releases would still be published. We need to add ablacklisted_crates
table containing the names of those crates, and change the docbuilder to refuse building those crates.The text was updated successfully, but these errors were encountered: