Skip to content

Make more fields non-null #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Make more fields non-null #1069

merged 1 commit into from
Sep 30, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Sep 26, 2020

Part of #874.

I ran the following queries in prod with 0 results:

select count(*) from queue where name is null;
select count(*) from queue where version is null;
select count(*) from queue where priority is null;
select count(*) from queue where attempt is null;
select count(*) from doc_coverage where release_id is null;
select count(*) from releases where version is null;
select count(*) from releases where rustdoc_status is null;
select count(*) from releases where build_status is null;
select count(*) from releases where have_examples is null;
select count(*) from releases where is_library is null;
select count(*) from authors where name is null;
select count(*) from owners where avatar is null;
select count(*) from owners where name is null;
select count(*) from crates where github_stars is null;

r? @Nemo157

@jyn514 jyn514 added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users labels Sep 26, 2020
@jyn514 jyn514 force-pushed the non-null branch 2 times, most recently from 00fdd04 to 817cec7 Compare September 26, 2020 17:25
@jyn514 jyn514 merged commit 0f67257 into rust-lang:master Sep 30, 2020
@jyn514 jyn514 deleted the non-null branch September 30, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants