migrate timestamp fields to timestamptz #1223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with some time on my hands I started on #1067 with the migration to timezone aware datetime fields.
In general I believe it's a good idea to be explicit about timezones also on the database level.
As we see, it simplifies quite some code :)
I'm happy to apply any changes needed (the column defaults actually don't have to be changed, since
NOW()
andCURRENT TIMESTAMP
already are timezone aware)Tests work locally, not sure what else needs to be tested.