Handle 404s and semver in source file viewer #1350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
commented
Apr 13, 2021
| let file_list = | ||
| FileList::from_path(&mut conn, &name, &version, &req_path).ok_or(Nope::NoResults)?; | ||
| let file_list = FileList::from_path(&mut conn, &crate_name, &version, &req_path) | ||
| .ok_or(Nope::ResourceNotFound)?; |
There was a problem hiding this comment.
This is what fixed the 500 error; before it was treating this as a search page and panicking because variables weren't set.
jyn514
commented
Apr 14, 2021
| @@ -16,7 +16,7 @@ macro_rules! ctry { | |||
| let request: &::iron::Request = $req; | |||
|
|
|||
| ::log::error!( | |||
| "called ctry!() on an `Err` value: {}\nnote: while attempting to fetch the route {:?}\n{:?}", | |||
| "called ctry!() on an `Err` value: {:?}\nnote: while attempting to fetch the route {:?}\n{:?}", | |||
There was a problem hiding this comment.
Without this it only shows the name of the template page that failed to render, not what the error actually was.
jyn514
added
the
S-waiting-on-review
7 tasks
Nemo157
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes
ctry!to print the debug version of errors so it's possible to see what goes wrong when a template fails to render.Closes #1344. Closes #1347.