Skip to content

Use --offline when building docs #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Use --offline when building docs #1882

merged 1 commit into from
Oct 15, 2022

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Oct 15, 2022

This reflects the intent of the command, since containers are isolated from the network. And it provides a clearer error message in case there is some problem and cargo would try to make a network request.

When building with (e.g.) CARGO_UNSTABLE_SPARSE_REGISTRY=true on the host, this produces errors like this:

2022/10/15 01:57:02 [INFO] rustwide::cmd: [stderr] error: failed to download `autocfg v1.1.0`
2022/10/15 01:57:02 [INFO] rustwide::cmd: [stderr]
2022/10/15 01:57:02 [INFO] rustwide::cmd: [stderr] Caused by:
2022/10/15 01:57:02 [INFO] rustwide::cmd: [stderr]   attempting to make an HTTP request, but --offline was specified

Related: #1881

This reflects the intent of the command, since containers are isolated from the
network. And it provides a clearer error message in case there is some problem
and cargo would try to make a network request.
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 15, 2022
@syphar syphar merged commit ceaf0a6 into rust-lang:master Oct 15, 2022
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 15, 2022
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants