Skip to content

migrate homepage, release-lists & search to axum #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

syphar
Copy link
Member

@syphar syphar commented Nov 25, 2022

This block of pages might get more requests, but the kind of request (DB queries + template rendering) matches other handlers that are already live.

Only more complex change is the search-handler, its request to crates.io, and the search-behaviour in general.

This changes the axum_redirect method that is introduced in #1925, I'll fix the conflicts when #1925 is merged.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Nov 25, 2022
@syphar syphar force-pushed the axum-more-releases branch from 142f2c7 to 902f48e Compare November 25, 2022 14:36
@syphar
Copy link
Member Author

syphar commented Nov 25, 2022

IMO the build-test failures are unrelated, timeouts from the GH package registry

@syphar syphar force-pushed the axum-more-releases branch 2 times, most recently from ecac377 to b79f611 Compare December 1, 2022 18:37
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a lot of changes 😅 I don't have any blocking concerns, but I worry that I missed something in review ...

@syphar syphar force-pushed the axum-more-releases branch from b79f611 to 7f2e726 Compare December 1, 2022 19:23
@syphar syphar merged commit a46af5d into rust-lang:master Dec 2, 2022
@syphar syphar deleted the axum-more-releases branch December 2, 2022 07:04
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Dec 2, 2022
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants