change error reporting for yank errors #1989
Merged
+95
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While digging into #1934 and the related sentry issue, I saw one thing:
after a build, we're already fetching the release-data from crates.io, and updating our release-record with the yank-status from the response.
docs.rs/src/docbuilder/rustwide_builder.rs
Lines 487 to 493 in 6b1505d
So this PR does:
warn
toerror
when the crates.io data can't be fetched.