Skip to content

Add dyn to trait objects to fix lint #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/db/migrate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ pub fn migrate(version: Option<Version>) -> CratesfyiResult<()> {

let mut migrator = Migrator::new(adapter);

let migrations: Vec<Box<PostgresMigration>> = vec![
let migrations: Vec<Box<dyn PostgresMigration>> = vec![
migration!(
// version
1,
Expand Down
4 changes: 2 additions & 2 deletions src/utils/build_doc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,13 @@ pub fn build_doc(name: &str, vers: Option<&str>, target: Option<&str>) -> Result
};

let ws = try!(Workspace::ephemeral(pkg, &config, Some(Filesystem::new(target_dir)), false));
let exec: Arc<Executor> = Arc::new(DefaultExecutor);
let exec: Arc<dyn Executor> = Arc::new(DefaultExecutor);
try!(ops::compile_ws(&ws, &opts, &exec));

Ok(try!(ws.current()).clone())
}

fn resolve_deps<'cfg>(pkg: &Package, config: &'cfg Config, src: Box<Source + 'cfg>)
fn resolve_deps<'cfg>(pkg: &Package, config: &'cfg Config, src: Box<dyn Source + 'cfg>)
-> CargoResult<Vec<(String, Package)>>
{
let mut registry = try!(PackageRegistry::new(config));
Expand Down
8 changes: 4 additions & 4 deletions src/web/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,10 @@ const OPENSEARCH_XML: &'static [u8] = include_bytes!("opensearch.xml");


struct CratesfyiHandler {
shared_resource_handler: Box<Handler>,
router_handler: Box<Handler>,
database_file_handler: Box<Handler>,
static_handler: Box<Handler>,
shared_resource_handler: Box<dyn Handler>,
router_handler: Box<dyn Handler>,
database_file_handler: Box<dyn Handler>,
static_handler: Box<dyn Handler>,
}


Expand Down