Load registry config to determine which API to use #813
Conversation
|
(I suggest hiding whitespace changes while viewing since the |
|
Built without problems (although I found some other regressions from past PRs while playing around: #817). |
|
I'll take a look at this PR on Monday. |
|
This looks good to me once we change the PR to set default values for any data it can't retrieve. Also, we should avoid creating multiple HTTP clients, ideally by sharing a single one even between builds. |
Nemo157
force-pushed
the
load-registry-config
branch
from
88992d3 to
2cbf252
Compare
src/index/api.rs
Outdated
| let (release_time, yanked, downloads) = self | ||
| .get_release_time_yanked_downloads(name, version) | ||
| .unwrap_or_else(|err| { | ||
| info!("Failed to get crate data for {}-{}: {}", name, version, err); |
There was a problem hiding this comment.
| info!("Failed to get crate data for {}-{}: {}", name, version, err); | |
| warn!("Failed to get crate data for {}-{}: {}", name, version, err); |
There was a problem hiding this comment.
I wasn't sure about whether this should be a warning given that not all registries might support it, but just 2 warning logs per build seems fine.
src/index/api.rs
Outdated
| }); | ||
|
|
||
| let owners = self.get_owners(name).unwrap_or_else(|err| { | ||
| info!("Failed to get owners for {}-{}: {}", name, version, err); |
There was a problem hiding this comment.
| info!("Failed to get owners for {}-{}: {}", name, version, err); | |
| warn!("Failed to get owners for {}-{}: {}", name, version, err); |
Nemo157
force-pushed
the
load-registry-config
branch
from
2cbf252 to
2923594
Compare
|
Thanks for working on this! What more do we have left until we can use staging.crates.io? |
Another step on the way towards #767, removes hardcoded
https://crates.io/apiurls and determines what to use based on the config in the registry index. The API is optional for a registry, so if configured to use a registry without one it will just insert empty data when building crates.