-
Notifications
You must be signed in to change notification settings - Fork 212
Moved all templates that use Release or CrateDetails to Tera #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get through everything, here are some initial comments.
- Can you remove the files in
templates/
that are no longer used? - It looks like the
/releases/authors
page now shows the date the latest release was built instead of the number of github stars. Was that intentional?
Oops, missed this the first time. It should be pretty clear I think when part of the site is missing since it will give 404s, if we don't catch it in the test suite that's a good opportunity to improve the test suite (we can test by hand since each template only has a few corresponding pages). So I think we should try to remove them as we go. |
The problem is that the current templates have almost no segmentation, everything at this stage is super intertwined. I can still try though, I just doubt it'll be fun |
398b65e
to
6df0832
Compare
758efec
to
9da4f57
Compare
I addressed all comments and I changed the authors page to have stars again (Note that stars are 0 because I don't have github set up locally) I also added a title to the authors page that shows the relative date to when the crate was published just for fun The failure for the docker build came from #864, I fixed it in my final commit (the
|
Can you split that out into a separate PR so we can merge it right away? |
I opened #867 for an independent fix |
9da4f57
to
3f8c999
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once nits are addressed
2eed0ac
to
3fff667
Compare
Co-authored-by: Joshua Nelson <[email protected]>
…s and a status to robots.txt
e6e32d7
to
bffd520
Compare
bffd520
to
5eedd25
Compare
ea4f038
to
202457f
Compare
This is unfortunately a really large PR and I apologize, but there wasn't really any other choice since they're all interdependent on how
Release
andCrateDetails
serialize. I didn't delete any handlebars templates since at this stage all the inter-dependence is really fuzzy and hard to discern, so I think it's just not worth the risk of deleting an entire segment of the site. It should only be 2 or three more PRs after this, so it shouldn't be a huge deal to keep them around for a bitThis is best taken by commit, each commit deals with one single template (which can amount to multiple pages in some cases).
Commit 1
Release Feed
Before
Formatted for readability
After
Pre-formatted
Commit 2
Home
Before
After
Commit 3
Recent Releases
Before
After
Releases by Stars
Before
After
Recent Failures
Before
After
My machine can't build crates for some reason
Failures by Stars
Before
After
My machine can't build crates for some reason
Commit 4
Authors
Before
After
Commit 5
Search
Before
After
Commit 6
Failed Search
Before
After
Failed empty Search
Before
After