Skip to content

Link to documentation, not to /crate on homepage #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions src/web/releases.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1035,13 +1035,33 @@ mod tests {
let web = env.frontend();
assert_success("/", web)?;

env.db().fake_release().name("some_random_crate").create()?;
env.db()
.fake_release()
.name("some_random_crate_that_failed")
.name("crate_that_succeeded")
.version("0.1.0")
.create()?;
env.db()
.fake_release()
.name("crate_that_failed")
.version("0.1.0")
.build_result_successful(false)
.create()?;
assert_success("/", web)
let home_page = kuchiki::parse_html().one(web.get("/").send()?.text()?);
let releases: Vec<_> = home_page
.select("a.release")
.expect("missing heading")
.collect();
assert_eq!(2, releases.len(), "expected 2 releases");
for release in releases {
let attributes = release.attributes.borrow();
let url = attributes.get("href").unwrap();
if url.contains("crate_that_succeeded") {
assert_eq!(url, "/crate_that_succeeded/0.1.0/crate_that_succeeded");
} else {
assert_eq!(url, "/crate/crate_that_failed/0.1.0");
}
}
Ok(())
})
}

Expand Down
2 changes: 1 addition & 1 deletion tera-templates/core/home.html
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ <h1 class="brand"><i class="fa fa-cubes fa-fw"></i> Docs.rs</h1>

<ul>
{%- for release in recent_releases -%}
{%- if rustdoc_status -%}
{%- if release.rustdoc_status -%}
{%- set release_url = "/" ~ release.name ~ "/" ~ release.version ~ "/" ~ release.target_name -%}
{%- else -%}
{%- set release_url = "/crate/" ~ release.name ~ "/" ~ release.version -%}
Expand Down