-
Notifications
You must be signed in to change notification settings - Fork 212
Storage refactorings #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage refactorings #902
Conversation
0254603
to
4eadd5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! This should finally unblock the switch to tokio 🎉 and improve our response times by a lot now that we're no longer creating a new runtime for each request.
Wait hold on, it looks like a runtime is still created each time |
Addressed all review comments. |
b7f50ec
to
c6d1143
Compare
This PR includes the first batch of refactorings to the storage subsystem to better support build tests. The most notable change is we're now using a single instance of
Storage
across the whole application, instead of creating a new one every time we need to use it.This doesn't contain all the changes to the storage I need to make: namely I first need to move all the configuration to
Config
. This PR is starting to get big though and rebasing it is a pain, so I submitted it earlier.This is best reviewed commit-by-commit.