-
Notifications
You must be signed in to change notification settings - Fork 212
Split up the about page #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I love the centered TOML, we should keep that in the final styling 😁 One suggestion: put a breadcrumb back to the main "About" page in the header of each page:
|
@Shnatsel what do you think? This is /about/builds: https://user-images.githubusercontent.com/23638587/89107717-f55fb480-d400-11ea-962f-c3b94d975607.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"How you can configure a build" is something I'd click if I was having trouble with my package building. Perhaps make it link to builds page?
Other than that LGTM. Thanks!
'How you can configure a build' is a different section - it's about |
This is ready for re-review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after nits, thanks!
Co-authored-by: Chase Wilson <[email protected]>
Co-authored-by: Chase Wilson <[email protected]>
- Redirections -> Shorthand URLs - Use `road` icon instead of `bicycle`
User visible changes
#[cfg]
}' sectionsInternal changes
impl_webpage
Addresses #923, #888.