Avoid writes without any data in write_all_vectored #2187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Cargo.toml the feature is called "write-all-vectored" (with "-"), in the code it used "write_all_vectored" (with "_"), this commit fixes the code to use the correct name. Also fixes the example.
Previously, when non-empty sequence of empty IoSlices have been provided to write_all_vectored, the buffers would be written as is with write_vectored, and subsequently the return value of Ok(0) would be misinterpreted as an error. Avoid writes without any data by advancing the buffers first. This is analogous to behaviour of write_all which makes no attempt to write if there is no data.
|
Ping @taiki-e. |
taiki-e
approved these changes
Jul 20, 2020
|
rust-lang/rust#74088 is merged, can this be merged as well? |
|
Since this has been reviewed, can it also be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when non-empty sequence of empty IoSlices have been provided
to write_all_vectored, the buffers would be written as is with
write_vectored, and subsequently the return value of Ok(0) would be
misinterpreted as an error.
Avoid writes without any data by advancing the buffers first. This is
analogous to behaviour of write_all which makes no attempt to write if
there is no data.
Includes #2181.