stream::ForEach can no longer block indefinitely #2224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the `loop` from `stream::ForEach`. Instead, the future makes at most 1 attempt to poll its interior, and if it can make more progress, it immediately calls `wake_by_ref()`, then returns Pending. In this way, under a fair executor, it can't accidentally starve the task queue.
|
I'm skeptical of this approach-- see my the related discussion between myself, @jonhoo , and @carllerche in this thread: #2049 (comment) I also anticipate that this PR would have significant negative performance implications if we adopted this approach throughout the ecosystem: yielding back up to the top-level executor with every step seems like it would interact poorly with locality, and could be very inefficient depending on the top-level executor's queuing implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
loopfromstream::ForEach. Instead, the futuremakes at most 1 attempt to poll its interior, and if it can make more
progress, it immediately calls
wake_by_ref(), then returns Pending.In this way, under a fair executor, it can't accidentally starve the
task queue.