small change in select example.
#2345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous example one future always finished first (because of implementation details), possibly confusing users about what `select` does. This commit resolves the issue by being explicit about one future finishing before the other.
Closed
taiki-e
reviewed
Feb 14, 2021
Co-authored-by: Taiki Endo <[email protected]>
taiki-e
approved these changes
Feb 14, 2021
This was referenced Mar 12, 2021
exrook
pushed a commit
to exrook/futures-rs
that referenced
this pull request
Apr 5, 2021
In the previous example one future always finished first (because of implementation details), possibly confusing users about what `select` does. This commit resolves the issue by being explicit about one future finishing before the other. Co-authored-by: tungli <[email protected]> Co-authored-by: Taiki Endo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous example one future always finished first (because of implementation details), possibly confusing users about what
selectdoes.This commit resolves the issue by being explicit about one future finishing before the other.
Closes #2334