added test for filter_map function of streams #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am confused by the coverage check failure. I added a test but it still says that coverage decreased. |
|
Thanks! Yeah I'd be totally fine splitting up the tests, feel free to do so! |
|
Ok, will do. Expect a PR in a few days. |
withoutboats
pushed a commit
that referenced
this pull request
Mar 25, 2018
As of rust-lang/rust#49194 it's now unsafe to resume a generator, but safe to create an immovable generator. Fixes #74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a unit test for filter_map of streams.
Right now in the adapters function.
After this I propose to split the adapters test function into many smaller functions, each covering on single function to test. That makes it somewhat easier to read and one could easily add more than one test case for each function without making the adapters function huge.
What do you think? I am happy to do it.