Skip to content

add #[derive(Debug)] to Matches struct; run cargo fmt; fix with clippy #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Conversation

Zaechus
Copy link
Contributor

@Zaechus Zaechus commented Nov 26, 2018

I added the Debug implementation to the Matches struct and associated data types. I also took the liberty to format the code with rustfmt and fix some small clippy lints. The lint changes shouldn't affect the functionality at all.

Fixes #64

Copy link
Contributor

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxgy!

I gave this a quick scan through, and couldn't spot any cases where clippy might've lead us to make any breaking changes.

@KodrAus KodrAus merged commit 87e60a0 into rust-lang:master Nov 26, 2018
@Zaechus
Copy link
Contributor Author

Zaechus commented Nov 26, 2018

The clippy lints were only for changing things like
!a.is_none() to a.is_some() or
a.len() > 0 to !a.is_empty() or
Err(_) to _,
so the library should behave the same way.

@KodrAus KodrAus mentioned this pull request May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add #[derive(Debug)] to struct Matches?
2 participants