Make url optional via a new "cred" feature gate for credential helpers #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an enabled-by-default feature flag for credential helpers, which are the only uses of the `url` crate. This reduces a `default-features = false` build of git2 from 54 dependencies to 17, for a configuration that many tools (e.g. anything that only cares about local repositories) can happily use. In addition to enabling it by default, make the "https" and "ssh" features depend on "cred".
joshtriplett
force-pushed
the
cred-feature
branch
from
4cc6bed to
da9c98d
Compare
joshtriplett
added a commit
to joshtriplett/lstr
that referenced
this pull request
Jun 18, 2025
…inary size With current git2, this reduces lstr from 144 dependencies to 137, and from 4.3M to 3.6M. With rust-lang/git2-rs#1168 merged into upstream git2-rs, it further reduces lstr to 107 dependencies (though with negligible additional improvement to binary size as the additional dependencies were compiled out).
joshtriplett
added a commit
to joshtriplett/lstr
that referenced
this pull request
Jun 18, 2025
…inary size With current git2, this reduces lstr from 144 dependencies to 137, and from 4.3M to 3.6M. With rust-lang/git2-rs#1168 merged into upstream git2-rs, it further reduces lstr to 106 dependencies (though with negligible additional improvement to binary size as the additional dependencies were compiled out).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an enabled-by-default feature flag for credential helpers, which are
the only uses of the
urlcrate. This reduces adefault-features = falsebuild of git2 from 54 dependencies to 17, fora configuration that many tools (e.g. anything that only cares about
local repositories) can happily use.
In addition to enabling it by default, make the "https" and "ssh"
features depend on "cred".