Skip to content

Add configure_make: Set MAKEFLAGS & MFLAGS #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Add configure_make: Set MAKEFLAGS & MFLAGS #42

merged 2 commits into from
Jul 5, 2022

Conversation

NobodyXu
Copy link
Contributor

@NobodyXu NobodyXu commented Jul 1, 2022

Fixed #24

Signed-off-by: Jiahao XU [email protected]

@alexcrichton
Copy link
Member

I don't want to undo 6ac9e7c, but I think making this opt-in is ok.

NobodyXu added 2 commits July 2, 2022 13:23
instead of modifing `configure`

Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Copy link
Contributor Author

NobodyXu commented Jul 2, 2022

I don't want to undo 6ac9e7c, but I think making this opt-in is ok.

I've added a new function configure_make that sets MAKEFLAGS and MFLAGS in additional to CARGO_MAKEFLAGS to keep backward compatibility.

@NobodyXu NobodyXu changed the title Fix configure: Set MAKEFLAGS & MFLAGS Add configure_make: Set MAKEFLAGS & MFLAGS Jul 2, 2022
@alexcrichton alexcrichton merged commit 888d2d7 into rust-lang:master Jul 5, 2022
@alexcrichton
Copy link
Member

👍

@NobodyXu NobodyXu deleted the fix/configure-make branch July 5, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client::configure can't be used to call e.g. make
2 participants