Skip to content

lang agenda generator ignores lang-nominated closed issues #199

@pnkfelix

Description

@pnkfelix
Member

If someone tags a closed issue (specifically, a merged PR) as I-lang-nominated, it does not get picked up by our current meeting agenda generator.

See for example: rust-lang/rust#106323

Activity

apiraino

apiraino commented on Feb 9, 2023

@apiraino

Relevant code in the lang agenda generator of the triagebot

joshtriplett

joshtriplett commented on Feb 10, 2023

@joshtriplett
Member

I had the impression this was intentional (so that we could close issues without having to un-nominate them), but no objection to changing it if folks want to bring closed things to our attention.

joshtriplett

joshtriplett commented on Feb 14, 2023

@joshtriplett
Member

We seem to have a rough consensus in favor of doing this; let's go ahead and make this change to the agenda generator.

apiraino

apiraino commented on Feb 14, 2023

@apiraino

Note: removing that flag will pull any old I-lang-nominated (likely already discussed) from these repositories:

("rust-lang", "rfcs"),
("rust-lang", "rust"),
("rust-lang", "reference"),
("rust-lang", "lang-team"),
("rust-lang", "compiler-team")

so probably a cleanup of I-lang-nominated from old issues will help :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @joshtriplett@pnkfelix@apiraino

        Issue actions

          lang agenda generator ignores lang-nominated closed issues · Issue #199 · rust-lang/lang-team