-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Listed in
Labels
C-bugCategory: bugCategory: bugE-mediumE-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate.E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate.breakage-candidate
Milestone
Description
It's common for C APIs to define constant values to denote the "last" value in a set of constants, like ELAST
or IPPROTO_MAX
. This seems prone to weird bugs, and these constants provide very marginal benefit to Rust programmers. Since we're considering some breakage anyways, we should just remove these values where we are made aware of them.
See:
JohnTitor
Metadata
Metadata
Assignees
Labels
C-bugCategory: bugCategory: bugE-mediumE-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate.E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate.breakage-candidate
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
JohnTitor commentedon Mar 3, 2023
👍, before 0.3, I'd like to deprecate these values.
JohnTitor commentedon Apr 19, 2023
Noticed that we have a lot of
*MAX
consts and deprecating manually is quite hard. We could write a script but it can cause a false positive, hmm. For now, I've edited the PR template to mention this concern.Auto merge of #3207 - JohnTitor:placeholder-pr-template, r=JohnTitor
ucontext_t
on aarch64-apple-darwin #3312SO_PROTOCOL
andSO_DOMAIN
on OpenBSD and Solarish. #3316295 remaining items
Debug
#4624sigval
#4637