Skip to content

Add tests for others android platforms #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malbarbo opened this issue Feb 23, 2017 · 2 comments · Fixed by #538
Closed

Add tests for others android platforms #536

malbarbo opened this issue Feb 23, 2017 · 2 comments · Fixed by #538

Comments

@malbarbo
Copy link
Contributor

The libc-test runs for arm-linux-android. It would be great if it were also run for aarch64-linux-android and i686-linux-android.
@malbarbo
Copy link
Contributor Author

@alexcrichton I have a local git branch that add tests for these platforms. I had to update the android sdk from 24.4.1 to 25.2.5 (last version) to run aarch64 tests. Some tests are failing, I will try to fix them.

Would you accept such PR?

Should I have one container for each platform, or just one container? The container's size with the three platforms are about 15GB. Is it a problem?

@alexcrichton
Copy link
Member

I'd love to add more platforms! PRs are of course always welcome :)

And yeah for now let's stick to a container-per-platform, and size shouldn't be a problem (I think the current image is huge)

@malbarbo malbarbo mentioned this issue Feb 24, 2017
Merged
bors added a commit that referenced this issue Feb 28, 2017
@bors
Auto merge of #538 - malbarbo:ci-android, r=alexcrichton
1fa8e30 
Add and fix tests for {i686, aarch64}-linux-android targets

I think that these changes do not breaks compatibility.

There are some types and constants changes to i686 and aarch64, but I see these changes as bug fixes instead of breaking changes. Also the type time64_t was remove from aarch64 because it is not defined in this arch.

Fixes #536
bors added a commit that referenced this issue Mar 1, 2017
@bors
Auto merge of #538 - malbarbo:ci-android, r=alexcrichton
612a586 
Add and fix tests for {i686, aarch64}-linux-android targets

I think that these changes do not breaks compatibility.

There are some types and constants changes to i686 and aarch64, but I see these changes as bug fixes instead of breaking changes. Also the type time64_t was remove from aarch64 because it is not defined in this arch.

Fixes #536
@bors bors closed this as completed in #538 Mar 1, 2017
danielverkamp pushed a commit to danielverkamp/libc that referenced this issue Apr 28, 2020
@japaric @alexcrichton
generate docs for Cortex-M / Cortex-R intrinsics (rust-lang#536)
05c2f61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add and fix tests for {i686, aarch64}-linux-android targets malbarbo/libc
2 participants
@alexcrichton @malbarbo