Skip to content

Add ENOATTR for Android #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Add ENOATTR for Android #1030

merged 1 commit into from
Jul 5, 2018

Conversation

mati865
Copy link
Member

@mati865 mati865 commented Jul 4, 2018

PR based on #594

It's defined in Android sysroot so it should work without test workaround (CI should catch it otherwise?).

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@mati865
Copy link
Member Author

mati865 commented Jul 4, 2018

cargo:warning=/checkout/target/x86_64-linux-android/debug/build/libc-test-a83d36f94edd2cc5/out/main.c:17374:51: error: 'ENOATTR' undeclared here (not in a function)
cargo:warning=             static int __test_const_ENOATTR_val = ENOATTR;
cargo:warning=                                                   ^

Apparently tests fail without workaround.

@mati865 mati865 force-pushed the android_enoattr branch from ac56590 to 27043ec Compare July 4, 2018 18:35
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 5, 2018

📌 Commit 27043ec has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 5, 2018

⌛ Testing commit 27043ec with merge 4dd6665...

bors added a commit that referenced this pull request Jul 5, 2018
Add ENOATTR for Android

PR based on #594

It's defined in Android sysroot so it should work without test workaround (CI should catch it otherwise?).
@bors
Copy link
Contributor

bors commented Jul 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 4dd6665 to master...

@bors bors merged commit 27043ec into rust-lang:master Jul 5, 2018
@mati865 mati865 deleted the android_enoattr branch July 5, 2018 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants