Add various strcase* functions and getline

[palfrey]

Adds

• strcasestr
• strcasecmp
• strncasecmp
• getline

I think they're semi-universal, but shall see what CI pops up...

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[gnzlbg]

It appears that the freebsd image used in CI lacks getline. Maybe a header is missing in the libc-test/build.rs for freebsd ? Otherwise you might want to take a look at whether more recent freebsd versions expose this.

[palfrey]

@gnzlbg https://www.freebsd.org/cgi/man.cgi?query=getline&apropos=0&sektion=0&manpath=FreeBSD+8.2-RELEASE&format=html indicates FreeBSD 8.0+ has getline, but only if you define _WITH_GETLINE, so let's try that...

[gnzlbg]

r? @gnzlbg

@palfrey please ping me when CI is green

[gnzlbg]

@bors: r+

[bors]

📋 Looks like this PR is still in progress, ignoring approval.

Hint: Remove [WIP] from this PR's title when it is ready for review.

[gnzlbg]

The windows msvc toolchains (the gnu ones are ok) are failing with:

C:\projects\libc\target\x86_64-pc-windows-msvc\debug\build\libc-test-9926ed016ab2f41f\out\main.c(591): error C2065: 'strcasecmp': undeclared identifier
C:\projects\libc\target\x86_64-pc-windows-msvc\debug\build\libc-test-9926ed016ab2f41f\out\main.c(591): warning C4047: 'return': 'int (__cdecl *)(const char *,const char *)' differs in levels of indirection from 'int'
C:\projects\libc\target\x86_64-pc-windows-msvc\debug\build\libc-test-9926ed016ab2f41f\out\main.c(596): error C2065: 'strncasecmp': undeclared identifier
C:\projects\libc\target\x86_64-pc-windows-msvc\debug\build\libc-test-9926ed016ab2f41f\out\main.c(596): warning C4047: 'return': 'int (__cdecl *)(const char *,const char *,std::size_t)' differs in levels of indirection from 'int'

Could you take a look?

[bors]

☔ The latest upstream changes (presumably #1129) made this pull request unmergeable. Please resolve the merge conflicts.

[gnzlbg]

I think it would be good to add these to redox, cloudabi, etc. as well.

[palfrey]

I dug through https://github.com/redox-os/relibc and https://github.com/NuxiNL/cloudlibc and added all of these functions that I could find there, along with what I think is the right header support...

[palfrey]

Uh, so I think all the Travis failures are nothing to do with this branch e.g.

+docker build -t libc -f ci/docker/sparc64-unknown-linux-gnu/Dockerfile ci/
Sending build context to Docker daemon    107kB
Step 1/7 : FROM debian:stretch
stretch: Pulling from library/debian
age configuration: unknown blob

Can we kick it in some way to rebuild and try again?

[gnzlbg]

@bors: r+

[bors]

💔 Test failed - status-travis

[gnzlbg]

@bors: try

[gnzlbg]

@bors: retry

[bors]

⌛ Trying commit 75071fe with merge 6ef0a8e...

[bors]

💔 Test failed - status-travis

[gnzlbg]

@bors: retry

[bors]

⌛ Trying commit 75071fe with merge e4a81c7...

[bors]

💔 Test failed - status-travis

[palfrey]

b05e058 is a bit of a hack, but I managed to hit (temporarily) one of the Travis issues locally and manually pulling the Docker images before building seemed to fix the problem

[alexcrichton]

@bors: r+

[bors]

📌 Commit 0942070 has been approved by alexcrichton

[palfrey]

Good news: down to just 1 failure ;)
Bad news: Failure on sparc64-unknown-linux-gnu

+ curl -LO https://cdimage.debian.org/cdimage/ports/9.0/sparc64/iso-cd/debian-9.0-sparc64-NETINST-1.iso
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   362  100   362    0     0    456      0 --:--:-- --:--:-- --:--:--   456
  0     0    0     0    0     0      0      0 --:--:--  0:05:01 --:--:--     0
curl: (28) Operation timed out after 300808 milliseconds with 0 out of 0 bytes received

Pretty sure this still isn't due to this PR...

[bors]

⌛ Testing commit 0942070 with merge 717d77e...

[bors]

💔 Test failed - status-travis

[palfrey]

@bors: retry

[bors]

@palfrey: 🔑 Insufficient privileges: not in try users

[alexcrichton]

@bors: retry

[bors]

⌛ Testing commit 0942070 with merge aee584c...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing aee584c to master...

[gnzlbg]

Thank you!