Skip to content

Marking nl_pad as public so we can construct sockaddr_nl #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

WillYu91
Copy link

Addressing issue 1135

#1135

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 22, 2018

I suppose that nl_pad are padding bits required for the ABIs to match. I wonder if one shouldn't be using hererepr(align), repr(packed), etc. instead. @alexcrichton ?

@alexcrichton
Copy link
Member

repr(align) is fine to use yeah, repr(packed) I believe is still feature gated

@gnzlbg
Copy link
Contributor

gnzlbg commented Jan 21, 2019

Any progress here? @WillYee please use repr(align)/repr(packed)/etc. to remove the padding field instead of making it public.

@gnzlbg
Copy link
Contributor

gnzlbg commented Feb 7, 2019

I'm closing this, since it is intended for this to be an internal implementation detail. See #1135 for how to initialize these structs.

@gnzlbg gnzlbg closed this Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants