add FIO* for FreeBSD and NetBSD #1200
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 6ce007f has been approved by |
|
@bors: r+ |
|
📌 Commit f97d3c4 has been approved by |
|
@alexcrichton Is something up with homu? I would expect it to have tested and/or merged by now? |
|
I've kicked a build to try to make progress |
add FIO* for FreeBSD and NetBSD Calculated [here](https://repl.it/repls/PaltryTroubledMonitors) from FreeBSD [source](https://github.com/freebsd/freebsd/blob/9867e6d8fe1cac34121e5f2df9357363f5659617/sys/sys/filio.h). Calculated [here](https://repl.it/repls/ProfitableImpracticalComputeranimation) from NetBSD [source](https://github.com/NetBSD/src/blob/64b8a48e1288eb3902ed73113d157af50b2ec596/sys/sys/filio.h). Some of these are likely identical across all BSDs – if this can be confirmed they could be elevated to `unix/bsd/mod.rs` alongside `FIOCLEX` and `FIONBIO`.
|
💔 Test failed - checks-travis |
|
Failure is due to rust-lang/rust#57488. @alexcrichton If you're able to retry when that's resolved, thanks! |
|
@bors: retry |
add FIO* for FreeBSD and NetBSD Calculated [here](https://repl.it/repls/PaltryTroubledMonitors) from FreeBSD [source](https://github.com/freebsd/freebsd/blob/9867e6d8fe1cac34121e5f2df9357363f5659617/sys/sys/filio.h). Calculated [here](https://repl.it/repls/ProfitableImpracticalComputeranimation) from NetBSD [source](https://github.com/NetBSD/src/blob/64b8a48e1288eb3902ed73113d157af50b2ec596/sys/sys/filio.h). Some of these are likely identical across all BSDs – if this can be confirmed they could be elevated to `unix/bsd/mod.rs` alongside `FIOCLEX` and `FIONBIO`.
|
☀️ Test successful - checks-cirrus, checks-travis, status-appveyor |
|
This appears to break the build on NetBSD 8.0. I'm currently seeing two relevant errors with the build:
And two seemingly unrelated errors:
|
|
@inferiorhumanorgans Good catch, sorry for missing this. They'll be in an upcoming NetBSD release but aren't in the latest. While this doesn't impact libc-consumers, failing the testsuite on latest NetBSD isn't ideal. I've PR'd to comment them out. When the next NetBSD ships with them included we can uncomment. |
Calculated here from FreeBSD source.
Calculated here from NetBSD source.
Some of these are likely identical across all BSDs – if this can be confirmed they could be elevated to
unix/bsd/mod.rsalongsideFIOCLEXandFIONBIO.