-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Test that targets without a shipping libcore / libstd build properly #1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gnzlbg: no appropriate reviewer found, use r? to override |
r? @gnzlbg (would be nice if some other people could review this, i'm unsure whether the bitrig fix is ok) |
3fa7df6
to
ec7cb08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So with this PR, Travis will cross compile OSes like Dragonfly from both Linux and OSX? Isn't that redundant? What coverage does libc gain by cross-compiling from two different hosts?
For the targets implemented in this PR, yes. I'm unsure if any of these tier2/tier3 targets can only be targeted by some toolchains, but AFAIK not all toolchains can cross-compile to all targets, e.g., the x86_64-apple-darwin can cross-compile to
None I think, it was just easier CI wise to enable this, but I guess I should just enable this for Linux, and if we need something more in the future, then we'll enable it then. |
While this builds, it still doesn't pass the tests that were failing in my PR. Would it not make sense to merge my PR and then rebase this on top of it? |
Yes, this only fix the "build" part of it, it does not run the |
@asomers I've addresses the issues, thoughts? |
Honestly, no. This is fairly far outside of my area of expertise. |
No thoughts? Or that some of the issues have not been addressed? |
cc @alexcrichton could you review this ? |
So i've removed the I'll merge this as soon as CI is green, cc @Susurrus if you want to continue the work with the |
9993ef1
to
5f9be7e
Compare
4893b20
to
16d7b32
Compare
16d7b32
to
7017701
Compare
All looks reasonable to me! |
There was some trouble with building the documentation of some of the targets that are built with That's a more general approach that we could use in the "build-only jobs", to avoid having to keep track of which targets can be built with cargo, and which one need cargo, but we can always do that later. @bors: r+ |
📌 Commit a25a42b has been approved by |
Test that targets without a shipping libcore / libstd build properly This PR tests that `libc` builds on targets that currently don't ship a `libcore`/`libstd` by cross-compiling to them from Linux and MacOSX using `Xargo`. This fixes the build on DragonflyBSD (superseeds #1237), Haiku, bitrig, and OpenBSD (superseeds #1259). cc @asomers @strangelittlemonkey @semarie
💥 Test timed out |
@bors: retry |
Test that targets without a shipping libcore / libstd build properly This PR tests that `libc` builds on targets that currently don't ship a `libcore`/`libstd` by cross-compiling to them from Linux and MacOSX using `Xargo`. This fixes the build on DragonflyBSD (superseeds #1237), Haiku, bitrig, and OpenBSD (superseeds #1259). cc @asomers @strangelittlemonkey @semarie
💔 Test failed - checks-travis |
@bors: retry |
Test that targets without a shipping libcore / libstd build properly This PR tests that `libc` builds on targets that currently don't ship a `libcore`/`libstd` by cross-compiling to them from Linux and MacOSX using `Xargo`. This fixes the build on DragonflyBSD (superseeds #1237), Haiku, bitrig, and OpenBSD (superseeds #1259). cc @asomers @strangelittlemonkey @semarie
💔 Test failed - checks-travis |
@bors: retry |
Test that targets without a shipping libcore / libstd build properly This PR tests that `libc` builds on targets that currently don't ship a `libcore`/`libstd` by cross-compiling to them from Linux and MacOSX using `Xargo`. This fixes the build on DragonflyBSD (superseeds #1237), Haiku, bitrig, and OpenBSD (superseeds #1259). cc @asomers @strangelittlemonkey @semarie
💔 Test failed - checks-cirrus |
☀️ Test successful - checks-cirrus, checks-travis, status-appveyor |
This PR tests that
libc
builds on targets that currently don't ship alibcore
/libstd
by cross-compiling to them from Linux and MacOSX usingXargo
.This fixes the build on DragonflyBSD (superseeds #1237), Haiku, bitrig, and OpenBSD (superseeds #1259).
cc @asomers @strangelittlemonkey @semarie