Skip to content

Redox CI #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Redox CI #1403

wants to merge 4 commits into from

Conversation

jackpot51
Copy link
Contributor

This does the following:

  • Fix compilation on Redox
  • Add Redox (x86_64-unknown-redox) to the tier2 CI targets
  • Bump version to 0.2.59, so that the broken version 0.2.58 is superseded

@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

Copy link
Contributor Author

@jackpot51 jackpot51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redox CI should be tested before merging, I know it compiles for Redox locally but I do not know if it will work on Travis.

This may require rust-lang/rust#60547

@gnzlbg
Copy link
Contributor

gnzlbg commented Jun 21, 2019

There appear to still be lots of errors even when using ctest 0.2.14. Do the tests pass for you locally?

@gnzlbg
Copy link
Contributor

gnzlbg commented Jun 21, 2019

If the tests don't pass, you might want to add this CI job to the allowed_failures list for the moment, and once things are fixed upstream, try to get the test passing here.

@gnzlbg gnzlbg closed this Jul 6, 2019
@gnzlbg gnzlbg reopened this Jul 6, 2019
@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 6, 2019

Triggering a new CI-build. This still had lots of CI errors last time. Would you mind fixing those?

@gnzlbg gnzlbg mentioned this pull request Jul 6, 2019
@mati865
Copy link
Contributor

mati865 commented Jul 7, 2019

I think it's blocked on rust-lang/rust#60547

@bors
Copy link
Contributor

bors commented Jul 15, 2019

☔ The latest upstream changes (presumably c8aa8ec) made this pull request unmergeable. Please resolve the merge conflicts.

@newpavlov
Copy link
Contributor

Can you also add this fix?

@mati865
Copy link
Contributor

mati865 commented Jul 17, 2019

It won't be necessary after rust-lang/rust#60547

@newpavlov
Copy link
Contributor

newpavlov commented Jul 17, 2019

Right now libc is completely unusable on Redox target. And we don't know how long it will take for the rust-lang PR to get merged, while this PR can be merged relatively soon after the CI issues get fixed. Plus, even with the merged PRs, you will still have this bug on current and previous stable releases.

@gnzlbg
Copy link
Contributor

gnzlbg commented Aug 12, 2019

This needs rebasing.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 28, 2019

@jackpot51 any chance of getting back to this soon ? It would be great if you could run libc-test on redox, and update this to be "ABI compliant".

@jackpot51
Copy link
Contributor Author

Yes, I am very interested in that too. I'm just busy with trying to get rustc running on Redox

@JohnTitor
Copy link
Member

I'm going to close this as inactive, feel free to re-open it or submit another PR when you find some time to work on (I've made some progress on #1934 so rebooting should be simple).

@JohnTitor JohnTitor closed this Oct 17, 2020
@jackpot51 jackpot51 deleted the redox-ci branch April 26, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants