-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add copy_file_range() for Linux and Android #1476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
When was this function added and in which header is it defined? You might need to update libc-test/build.sh to only test it when the appropriate header is included, but it might be that the linux and android versions used in CI aren't new enough. |
|
I see, well let me know when CI is green. |
5846b17
to
06eadd4
Compare
Just now, |
That would require upgrading the musl versions used here on CI. |
☔ The latest upstream changes (presumably #1510) made this pull request unmergeable. Please resolve the merge conflicts. |
This needs rebasing |
@ArniDagur we have recently upgraded the musl version, would you mind rebasing this to see if it passes tests and can be merged? Let me know if there is anything I can help you with! |
06eadd4
to
0abe095
Compare
@gnzlbg The musl tests still fail. |
That probably means that the musl version used by CI still does not support this API. |
It was added in 1.1.24 (the same as on the CI) but it requires Line 2076 in 122ca90
|
Triage: |
This is my first PR to
libc
, so I looked at howsplice()
is implemented and modelled it after that.See http://man7.org/linux/man-pages/man2/copy_file_range.2.html