-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add initial support for sparc-unknown-linux-gnu #1567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
Can we try to re-run the rust-lang.libc test? The failure seems unrelated. |
@bors: r+ |
📌 Commit 25e71b1 has been approved by |
Add initial support for sparc-unknown-linux-gnu While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
💔 Test failed - status-azure |
Looks like there are unrelated test failures for some tests. Would a manual merge be possible? |
Yes, looks like nightly Rust broke a couple of libc jobs. Need to fix that upstream.
Sadly no, all PRs are blocked on the build being green, too many crates depend on libc. |
@gnzlbg Any idea when the CI will be working again? |
90bf188
to
f35ef37
Compare
Just rebased and force-pushed, should be good for merge after CI has finished. |
f35ef37
to
7b2e915
Compare
@bors: r+ |
📌 Commit 7b2e915 has been approved by |
Add initial support for sparc-unknown-linux-gnu While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
💥 Test timed out |
@bors: retry |
Add initial support for sparc-unknown-linux-gnu While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
💔 Test failed - status-azure |
@bors: retry |
Add initial support for sparc-unknown-linux-gnu While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
💔 Test failed - status-azure |
Same failure: same target and package that failed to download. |
@bors: retry Let's try one more time. |
Add initial support for sparc-unknown-linux-gnu While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
💔 Test failed - status-azure |
7b2e915
to
aede579
Compare
Rebased and pushed. Let's see if the CI is happier today. |
aede579
to
8b3b17f
Compare
@bors: r+ |
📌 Commit 8b3b17f has been approved by |
Add initial support for sparc-unknown-linux-gnu While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
💔 Test failed - checks-cirrus-freebsd-11 |
CI failed again for unrelated reasons :(. |
8b3b17f
to
034574c
Compare
@gnzlbg Can you approve again? |
Every time the source code is modified I need to review, and with the re-bases it is unclear to me what changed from the previous time I reviewed, so I kind of need to review all of it, which takes time. It would be simpler if new commits were independent commits. |
@bors: r+ |
📌 Commit 034574c has been approved by |
Add initial support for sparc-unknown-linux-gnu While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
@gnzlbg I'm just rebasing every time and then force-pushing to retrigger the testsuite. No changes. |
Ah, please don't do that. That re-triggers the test suite here, blocking the queue and preventing bors from trying to merge it, and requires re-reviewing the PR instead of just retrying it. It's better just to ping me :) |
☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.