Skip to content

Conversation

glaubitz
Copy link
Contributor

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.

@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@glaubitz
Copy link
Contributor Author

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned gnzlbg Oct 25, 2019
@glaubitz
Copy link
Contributor Author

Can we try to re-run the rust-lang.libc test? The failure seems unrelated.

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 25, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 25, 2019

📌 Commit 25e71b1 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Oct 25, 2019

⌛ Testing commit 25e71b1 with merge 1b179f2...

bors added a commit that referenced this pull request Oct 25, 2019
Add initial support for sparc-unknown-linux-gnu

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
@bors
Copy link
Contributor

bors commented Oct 25, 2019

💔 Test failed - status-azure

@glaubitz
Copy link
Contributor Author

Looks like there are unrelated test failures for some tests. Would a manual merge be possible?

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 27, 2019

Looks like there are unrelated test failures for some tests

Yes, looks like nightly Rust broke a couple of libc jobs. Need to fix that upstream.

Would a manual merge be possible?

Sadly no, all PRs are blocked on the build being green, too many crates depend on libc.

@glaubitz
Copy link
Contributor Author

glaubitz commented Nov 6, 2019

@gnzlbg Any idea when the CI will be working again?

@glaubitz
Copy link
Contributor Author

Just rebased and force-pushed, should be good for merge after CI has finished.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 19, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 19, 2019

📌 Commit 7b2e915 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Nov 19, 2019

⌛ Testing commit 7b2e915 with merge c881cac...

bors added a commit that referenced this pull request Nov 19, 2019
Add initial support for sparc-unknown-linux-gnu

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
@bors
Copy link
Contributor

bors commented Nov 19, 2019

💥 Test timed out

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 19, 2019

@bors: retry

@bors
Copy link
Contributor

bors commented Nov 19, 2019

⌛ Testing commit 7b2e915 with merge c23c911...

bors added a commit that referenced this pull request Nov 19, 2019
Add initial support for sparc-unknown-linux-gnu

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
@bors
Copy link
Contributor

bors commented Nov 19, 2019

💔 Test failed - status-azure

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 20, 2019

@bors: retry

@bors
Copy link
Contributor

bors commented Nov 20, 2019

⌛ Testing commit 7b2e915 with merge 9c6d085...

bors added a commit that referenced this pull request Nov 20, 2019
Add initial support for sparc-unknown-linux-gnu

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
@bors
Copy link
Contributor

bors commented Nov 20, 2019

💔 Test failed - status-azure

@glaubitz
Copy link
Contributor Author

Same failure: same target and package that failed to download.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 20, 2019

@bors: retry

Let's try one more time.

@bors
Copy link
Contributor

bors commented Nov 20, 2019

⌛ Testing commit 7b2e915 with merge fac614d...

bors added a commit that referenced this pull request Nov 20, 2019
Add initial support for sparc-unknown-linux-gnu

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
@bors
Copy link
Contributor

bors commented Nov 20, 2019

💔 Test failed - status-azure

@glaubitz
Copy link
Contributor Author

Rebased and pushed. Let's see if the CI is happier today.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 25, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 25, 2019

📌 Commit 8b3b17f has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Nov 25, 2019

⌛ Testing commit 8b3b17f with merge a5b6656...

bors added a commit that referenced this pull request Nov 25, 2019
Add initial support for sparc-unknown-linux-gnu

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
@bors
Copy link
Contributor

bors commented Nov 25, 2019

💔 Test failed - checks-cirrus-freebsd-11

@glaubitz
Copy link
Contributor Author

CI failed again for unrelated reasons :(.

@glaubitz
Copy link
Contributor Author

@gnzlbg Can you approve again?

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 25, 2019

Every time the source code is modified I need to review, and with the re-bases it is unclear to me what changed from the previous time I reviewed, so I kind of need to review all of it, which takes time. It would be simpler if new commits were independent commits.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 25, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 25, 2019

📌 Commit 034574c has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Nov 25, 2019

⌛ Testing commit 034574c with merge 7a12eed...

bors added a commit that referenced this pull request Nov 25, 2019
Add initial support for sparc-unknown-linux-gnu

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
@glaubitz
Copy link
Contributor Author

@gnzlbg I'm just rebasing every time and then force-pushing to retrigger the testsuite. No changes.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 25, 2019

Ah, please don't do that. That re-triggers the test suite here, blocking the queue and preventing bors from trying to merge it, and requires re-reviewing the PR instead of just retrying it.

It's better just to ping me :)

@bors
Copy link
Contributor

bors commented Nov 25, 2019

☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 7a12eed to master...

@bors bors merged commit 034574c into rust-lang:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants