Add sock_extended_err and associated constants from errqueue.h to linux_like #1616
Conversation
This moves the linux/ headers after others This keeps the Android tests closer to the Linux ones. I think this is needed to get linux/errqueue.h to not cause compilation failures.
sock_extended_err is a struct returned as a control message when the sockopt IP_RECVERR is set, when recvmsg has the MSG_ERRQUEUE flag set. IP_RECVERR and MSG_ERRQUEUE are constants both already defined here.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
CI failure was in: Can we re-run that assuming it was an intermittent outage/error? |
Modelled after the cmsg tests, this wraps the C macro into a function, and then compares the results to the Rust implementation in libc.
|
Actually, I just force-pushed to make CI re-run |
|
@gnzlbg I added a test per the other PR. Anything else I need here? |
|
Hi, anything I can do to get this merged? |
|
@bors: r+ |
|
📌 Commit 06938ad has been approved by |
Add sock_extended_err and associated constants from errqueue.h to linux_like This is an alternate version of #1614 that attempts to fix issues with the android ctests by rearranging the headers. Due to long CI cycle time, I've opened it as an alternate PR. Only one or the other should merge, depending if linux_like or linux is the correct place for this. sock_extended_err is a struct returned as a control message when the sockopt IP_RECVERR is set, when recvmsg has the MSG_ERRQUEUE flag set. IP_RECVERR and MSG_ERRQUEUE are constants both already defined here.
|
☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
|
thank you! |
This is an alternate version of #1614 that attempts to fix issues with the android ctests by rearranging the headers. Due to long CI cycle time, I've opened it as an alternate PR. Only one or the other should merge, depending if linux_like or linux is the correct place for this.
sock_extended_err is a struct returned as a control message when the sockopt
IP_RECVERR is set, when recvmsg has the MSG_ERRQUEUE flag set. IP_RECVERR and
MSG_ERRQUEUE are constants both already defined here.